Runners use separate directories to allow parallelism #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issues that are run into when running two separate unit tests in the same crate (see issue #58). Previously, doing this would cause the test runners to use the same crate directory, leading to one overwriting the other's manifest. This resulted in confusing errors and tests failing to no fault of the user.
To solve this, separate directories are defined for each run, using a hash of the test paths used by the
TestCase
. Therefore, the following now works correctly:This does add a dependency on
rustc-hash
, the hasher used withinrustc
. I would say this is a trustworthy additional dependency, as it is owned by the Rust core team. The hash is not cryptographic, but it doesn't need to be for this use case. If you would rather not add this dependency, let me know and we can discuss another way.